Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/libm/arch/i387



Joerg Sonnenberger <joerg%britannica.bec.de@localhost> writes:

> On Mon, Jun 20, 2011 at 11:25:34AM +0900, 
> tsugutomo.enami%jp.sony.com@localhost wrote:
>> Joerg Sonnenberger <joerg%NetBSD.org@localhost> writes:
>> 
>> > Log Message:
>> > Switch to SSE code, since our gas supports it now.
>> >
>> >
>> > To generate a diff of this commit:
>> > cvs rdiff -u -r1.6 -r1.7 src/lib/libm/arch/i387/s_copysign.S
>> > cvs rdiff -u -r1.5 -r1.6 src/lib/libm/arch/i387/s_copysignf.S
>> 
>> Is the change done in s_copysignf.S correct?
>
> It works, but why do you think it is incorrect?

I should ask if it is `what you intended' instead of `correct'.

Since what you did for thses two files are quite opposite, I guess one
of the changes is not waht you want.

For s_copysignf.S (not s_copysign.S), you simply removed already #if 0
outed code which uses pand/por instruction and it disagrees with commit
message.

enami.


Home | Main Index | Thread Index | Old Index