Re: CVS commit: src/tests/lib/libc/stdlib

[Adam Hamsik <haaaad%gmail.com@localhost>]

On Jun,Sunday 5 2011, at 12:58 AM, Jukka Ruohonen wrote:

> On Sat, Jun 04, 2011 at 10:49:49PM +0000, Adam Hamsik wrote:
>> Module Name: src
>> Committed By:        haad
>> Date:                Sat Jun  4 22:49:49 UTC 2011
>> 
>> Modified Files:
>>      src/tests/lib/libc/stdlib: t_strtol.c
>> 
>> Log Message:
>> Fix problem with overflowing constant definition
>> 
>> t_strtol.c:95: warning: overflow in implicit constant conversion
> 
> Can you note the architecture and explain the overflow so that I can
> learn something?

Architecture i386 - PAE,

#   compile  kern/strtoull.o
/usr/devel/buildslave/obj/i386/tooldir/bin/i486--netbsdelf-gcc -O2 -Wall -Os 
-ffreestanding -std=gnu99 -Werror  -march=i386 -mtune=i386  
--sysroot=/usr/devel/buildslave/obj/i386/destdir.i386 
-I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/arch/i386
 --sysroot=/usr/devel/buildslave/obj/i386/destdir.i386 -DSLOW -DSUPPORT_BOOTP 
-DSUPPORT_DHCP -DSUPPORT_TFTP -DBOOTROM -DRELOC=0x90000 -nostdinc 
-I/usr/devel/buildslave/obj/i386/sys/arch/i386/stand/netboot/3c509 
-I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../..
 
-I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../arch/i386/stand/lib
 
-I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libsa
 -D_STANDALONE 
-I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/quad
 
-I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/string
 
-I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/arch/i386/string
  
-I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/quad
 
-I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/string
 
-I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/arch/i386/string
 
-I/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/include
  -c    
/usr/devel/buildslave/full/build/sys/arch/i386/stand/netboot/3c509/../../../../../lib/libkern/../../../common/lib/libc/stdlib/strtoull.c
 -o strtoull.o
--- dependall-tests ---
cc1: warnings being treated as errors
/usr/devel/buildslave/full/build/tests/lib/libc/stdlib/t_strtol.c: In function 
'atfu_strtol_base_body':
/usr/devel/buildslave/full/build/tests/lib/libc/stdlib/t_strtol.c:95: warning: 
overflow in implicit constant conversion
/usr/devel/buildslave/full/build/tests/lib/libc/stdlib/t_strtol.c:96: warning: 
overflow in implicit constant conversion
*** [t_strtol.o] Error code 1
nbmake: stopped in /usr/devel/buildslave/full/build/tests/lib/libc/stdlib
1 error
nbmake: stopped in /usr/devel/buildslave/full/build/tests/lib/libc/stdlib

Please revert/fix my commit if I did it wrong. But I can compile -current with 
it.

Regards

Adam.