Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/xen/xen



On Wed, Apr 06, 2011 at 05:41:37PM +0100, Jean-Yves Migeon wrote:
> Yep, but there are other places where this will get tricky. For
> example, rc.conf(5) is parsed as a classic shell script [1]. Given
> that someone has two possibilities to configure interfaces:
> 
> /etc/ifconfig.xxx
> or
> ifconfig_xxx # in rc.conf(5)
> 
> If we follow the same "xxx" naming convention for both, we would
> have to 'tr' certain lines of rc.conf for interfaces that contains a
> [^a-zA-Z0-9_] char. This complexifies rc.conf parsing for no real
> benefit. Putting a ifconfig_xxx-yyy="auto" in rc.conf(5) will likely
> result in a parsing error.
> 
> I am about to revert my patch anyway, and use '_' instead. I will
> also update ifconfig.if(5) to clearly indicate that only chars
> accepted in shell variable names should be used.

You could also use
xvifxiy (e.g. xvif5i2, where i stands for 'index').
or any other letter ...

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--


Home | Main Index | Thread Index | Old Index