Re: CVS commit: src/lib/libbluetooth

[Iain Hibbert <plunky%rya-online.net@localhost>]

On Mon, 4 Apr 2011, Alan Barrett wrote:

> On Mon, 04 Apr 2011, Iain Hibbert wrote:
> > Modified Files:
> >     src/lib/libbluetooth: sdp_get.c
> >
> > Log Message:
> > handle overflowed values correctly,
> > also put a compile time guard to warn if INTMAX won't fit in INT64
> > (all our ports currently have INTMAX = INT64)
>
> The actual code tests
>
>    #if INTMAX_MAX < INT64_MAX
>
> which is the reverse of what the commit log says, and it's guaranteed by the
> C99 standard to never be true.  (intmax_t is guaranteed to be at least 64
> bits, and is guarantted to be the largest integral type.)

Sorry, the code test was correct though I did not see the bit about 64-bit
being minimum spec for intmax types (section 7.18.2.5), so the guard is
redundant and I will remove it

iain