Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys

On Tue, Mar 22, 2011 at 04:10:16PM +0000, Mindaugas Rasiukevicius wrote:
 > >    src/sys/kern: subr_pool.c vfs_lookup.c
 > >    src/sys/rump/librump/rumpkern: rump.c
 > > 
 > > Log Message:
 > > pnbuf_cache is used all over the place outside of vfs, so put it
 > > in one place to avoid many definitions.
 > Are you going to move random pools to subr_pool.c just because it is
 > more convenient for rumpkern?  This change breaks logical abstraction
 > without real justification.  Please revert.

I agree - almost all users should be using struct pathbuf, which is
isolated within vfs_lookup.c. There are a few outliers at this point,
but they should be tidied up, not catered to.

David A. Holland

Home | Main Index | Thread Index | Old Index