Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys

On Wed Jan 19 2011 at 01:10:10 +0900, Izumi Tsutsui wrote:
> > Added Files:
> >     src/sys/compat/common: kern_select_50.c
> Builds of most m68k ports failed since <sys/syscallargs.h> requires
> <sys/sched.h> for cpuset_t.

whoops ...

> Should we add it to all sources that include syscallargs.h,
> or just add <sys/sched.h> into $sysarghdrextra in sys/kern/syscalls.conf?
> Some other files still include <sys/mount.h> and <sys/sched.h>
> only for syscallargs.h.

I like self-contained headers, so sysarghdrextra has my vote.

Do you want to do the change and test, or should I?

(on a slight tangent, it is annoying to have MD differences in header
auto-inclusion, the most famous one being atomic.h included by x86 pmap.h)

älä karot toivorikkauttas, kyl rätei ja lumpui piisaa

Home | Main Index | Thread Index | Old Index