Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/tests/lib/libc

On Wed, 12 Jan 2011, Masao Uebayashi wrote:

On Tue, Jan 11, 2011 at 11:25:01PM +0000, Christos Zoulas wrote:

Module Name:    src
Committed By:   pgoyette
Date:           Tue Jan 11 16:30:54 UTC 2011

Modified Files:
        src/tests/lib/libc: Makefile
Added Files:
        src/tests/lib/libc/getaddrinfo: Makefile README basics_v4.exp
            basics_v4v6.exp h_gai.c no_host_v4.exp no_host_v4v6.exp
            no_serv_v4.exp no_serv_v4v6.exp scoped.exp sock_raw_v4.exp
            sock_raw_v4v6.exp spec_fam_v4.exp spec_fam_v4v6.exp

Log Message:
Atf-ify the getaddrinfo test, with updated "golden" output files.


Can you please move all this to src/tests/lib/libc/net/getaddrinfo to
reflect the structure in libc. I know others have been abusing it, but
I meant to fix all of it and adding more does not help.

Why not put unit tests in the original directories?
(Like src/lib/libc/net/getaddrinfo for this.)

The original test was already in the regress/... hierarchy where it wasn't getting any attention. It just seemed reasonable to me to move a regression test to our new location for regression tests. :)

At Christos's suggestion, I've already moved the getaddrinfo test

        from: src/test/lib/libc/getaddrinfo/*
        to:   src/test/lib/libc/net/getaddrinfo/*

If there are no objections, I'll likely move the servent and protoent tests into the ..../net directory, too. But not tonight! :)

| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index