Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/acpi

On Tue, Jan 04, 2011 at 12:52:57PM +0000, Mindaugas Rasiukevicius wrote:
> 1) There is a use-after-free.  Hint: TAILQ_FOREACH_SAFE().
> 2) It is not safe; while lock is dropped, the 'next' entry may also
> be removed and freed.  Hint: have a local list and avoid relocking.

Hmm. 2) implies that the whole sysmon_taskq(9) is not safe?

- Jukka.

PS. It is crazy to have "safe" and "unsafe" variants of these macros.

Home | Main Index | Thread Index | Old Index