Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/pci



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Dec 24, 2010, at 8:51 PM, Izumi Tsutsui wrote:

It is declared but not implemented. I got an 'undefined reference'
linking error.

Revert your change first. It's author's request and
you didn't test it on hardware. No positive reason to keep it.

Buildability of i386 ALL can't be an excuse in your case.
You should make it defined reference in MD implementation,
that's what the error pointed out.

Well, the change isn't harmful - this time - and using bus_space_read_8() there was most likely a typo I made. I just wanted to warn him against: - - making changes in drivers he can't test, trivial or not, since there can be side effects as you already pointed out
- - messing with drivers for hardware he's not remotely familiar with

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBTRViNcpnzkX8Yg2nAQK7XwgAssIFmjmDTlM6opBLBC/3hXxtGjlybDCP
ZTanG34+hqJ8ySdc+dpdpBoD3abAG6vWmrb1kW7chkbWQ6E2tY0gKr0a0A3jCbXb
6UwtpNaSkNNwwGtYqrHoD2W2JLq1vJY8NXm/1MI8ZA1pG/9UQ9SmneU8NxyZ7iOl
Flm8OJ8wvHiUpyL/3lLwLxjwdyH1J9svl7ZfqaW2s6uKy/eC6HoSX6+VLNKO2Srw
NrJlf+LpX1ilzgjMnVElo1Y7tUH78HWboTqqSwBT2MnRNT0fJDDVrm+N/X6TzkGv
N1xJM9WR+cznah6F8GoiMWi3pWGRQeY8d+YEsI5NPiUUp0YpzLEwyg==
=EUu+
-----END PGP SIGNATURE-----


Home | Main Index | Thread Index | Old Index