[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/dev/pci
-----BEGIN PGP SIGNED MESSAGE-----
On Dec 24, 2010, at 8:51 PM, Izumi Tsutsui wrote:
It is declared but not implemented. I got an 'undefined reference'
Revert your change first. It's author's request and
you didn't test it on hardware. No positive reason to keep it.
Buildability of i386 ALL can't be an excuse in your case.
You should make it defined reference in MD implementation,
that's what the error pointed out.
Well, the change isn't harmful - this time - and using
bus_space_read_8() there was most likely a typo I made. I just wanted
to warn him against:
- - making changes in drivers he can't test, trivial or not, since there
can be side effects as you already pointed out
- - messing with drivers for hardware he's not remotely familiar with
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
-----END PGP SIGNATURE-----
Main Index |
Thread Index |