Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/i386/stand/lib



On Sat, Dec 25, 2010 at 08:07:50AM +0900, Izumi Tsutsui wrote:
> > >Log Message:
> > >Sprinkle daddr_t.
> > >Adjust DISK_DEBUG printf formats to match.
>  :
> > >-          printf("warning: no disklabel in sector %u\n", sector);
> > >+          printf("warning: no disklabel in sector %lld\n", sector);
> > > #endif
> > 
> > Are you sure this is right? My guess is that you would need PRId64
> > instead of lld.
> 
> libsa's printf(3) doesn't support %lld unless
> -DLIBSA_PRINTF_LONGLONG_SUPPORT is specified.

True, that but it's not like this code path is often compiled.
I should probably at least add the necessary gunk commented out
in the makefile.


Home | Main Index | Thread Index | Old Index