Re: CVS commit: src/sys/arch/i386/stand/lib

["Jonathan A. Kollasch" <jakllsch%kollasch.net@localhost>]

On Fri, Dec 24, 2010 at 11:00:40PM +0000, Christos Zoulas wrote:
> In article <20101224203651.E3C41175D0%cvs.netbsd.org@localhost>,
> Jonathan A. Kollasch <source-changes-d%NetBSD.org@localhost> wrote:
> >-=-=-=-=-=-
> >
> >Module Name: src
> >Committed By:        jakllsch
> >Date:                Fri Dec 24 20:36:51 UTC 2010
> >
> >Modified Files:
> >     src/sys/arch/i386/stand/lib: biosdisk.c biosdisk.h biosdisk_ll.c
> >
> >Log Message:
> >Sprinkle daddr_t.
> >Adjust DISK_DEBUG printf formats to match.
> >
> >
> >To generate a diff of this commit:
> >cvs rdiff -u -r1.31 -r1.32 src/sys/arch/i386/stand/lib/biosdisk.c
> >cvs rdiff -u -r1.7 -r1.8 src/sys/arch/i386/stand/lib/biosdisk.h
> >cvs rdiff -u -r1.26 -r1.27 src/sys/arch/i386/stand/lib/biosdisk_ll.c
> >
> >Please note that diffs are not public domain; they are subject to the
> >copyright notices on the relevant files.
> >
> >@@ -178,7 +178,7 @@
> >     lp = (struct disklabel *) (d->buf + LABELOFFSET);
> >     if (lp->d_magic != DISKMAGIC || dkcksum(lp)) {
> > #ifdef DISK_DEBUG
> >-            printf("warning: no disklabel in sector %u\n", sector);
> >+            printf("warning: no disklabel in sector %lld\n", sector);
> > #endif
> 
> Are you sure this is right? My guess is that you would need PRId64
> instead of lld.
> 

Well, maybe.  But I expect int64_t will always be long long on i386.