Re: CVS commit: src/sys/dev/pci

[Michael <macallan%netbsd.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Dec 24, 2010, at 11:43 AM, Christoph Egger wrote:

> On 24.12.10 14:11, Michael wrote:
> > Hello,
> >
> > On Dec 24, 2010, at 4:13 AM, Christoph Egger wrote:
> >
> > > On 24.12.10 00:56, Michael wrote:
> > > > Hello,
> > > >
> > > > On Dec 23, 2010, at 4:34 PM, Christoph Egger wrote:
> > > >
> > > > > Module Name:    src
> > > > > Committed By:    cegger
> > > > > Date:        Thu Dec 23 21:34:02 UTC 2010
> > > >
> > > > > Modified Files:
> > > > >   src/sys/dev/pci: voyagerfb.c
> > > >
> > > > > Log Message:
> > > > > read 32bits instead of 64bits and truncate the upper 32bits
> > > >
> > > > Please stop making unnecessary changes to drivers you can't test on
> > > > actual hardware.
> >
> > > Sorry, should have mentioned this makes the i386 ALL kernel linking.
> >
> > Are you trying to tell me that i386 doesn't have bus_space_*_8()
> > methods? I'd call that a bug.
>
> It is declared but not implemented. I got an 'undefined reference'
> linking error.

That's about the worst possible reason for getting rid of a 64bit  
access. For all you know the hardware may need it. Either way,  
voyagerfb makes little to no sense on x86 anyway.

have fun
Michael


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBTRT59cpnzkX8Yg2nAQKQwQgAiupdJkHDbhr7YBl0VgjYALm9QGwrQKyZ
AZWzdssyawxW+d4ozEthpoDrF5Sm4aKzS4mJxbvazCdkl1cXj87fxuGyGI+dW1B6
kdP/tyBx4l2Ww3vwKpBfcVNkaJJUz9K44HSxA04ZpJd3hy5w0DwID7gNsbXrvfEi
3b8G/hPL2nncEyYjTA0lGyxCR0DDe1lvfRGuHDIAtKb3rYQzsTiWl6du7rAPqljZ
uvR1zeRWLDnYAfRY2taRZn3gsYiZ4dCIIVD1cXYlxe8FUifu2jnBPCuVxD7uRBBo
BNILtenUkIHijmKZFq6Hb8nTxUSzGDmWxvZL4RoGd8Beq/zi5UoIeA==
=DGbG
-----END PGP SIGNATURE-----