Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/i386/stand



On Fri, Dec 24, 2010 at 03:13:28PM +0000, David Laight wrote:
> On Wed, Dec 22, 2010 at 08:46:43PM +0000, Jonathan A. Kollasch wrote:
> > 
> > Log Message:
> > It just so happens we don't need -Wno-attributes if we
> > place __packed in the right place.
> 
> Does that need __packed (which would force unaligned access code)
> be added for all accesses, or just __attribute__((aligned(n))) for
> some fields?
> 
> This doesn't make much difference on i386, but will on archs that
> don't support misaligned accesses.

My intention here was only to make the existing code syntactically
correct, not second guess the original author's intentions.

Anyway, it's PXE, AFAIK that's i386-only anyway.

        Jonathan Kollasch


Home | Main Index | Thread Index | Old Index