Re: CVS commit: src/external/gpl2/lvm2

[christos%astron.com@localhost (Christos Zoulas)]

In article <FEFC4453-CDC4-4771-B16F-7F31C8555390%gmail.com@localhost>,
Adam Hamsik  <haaaad%gmail.com@localhost> wrote:

>> Index: src/external/gpl2/lvm2/dist/daemons/cmirrord/functions.c
>
>This file is not even build please revert your change.
>
>> Index: src/external/gpl2/lvm2/dist/libdm/ioctl/libdm-iface.c
>
>This is original linux file which is not build, please revert your change.

I think that the fixes are correct though, so I would prefer to ask
upstream to take them.

>PR is about block devices not about char control devices this part
>changes /dev/mapper/control do we really want to have 640 there if yes
>I'm fine with it I just want to be sure that you wanted to do that.

Yes that was problematic, and we needed to add permission checks
in the kernel portion. What's nice about it is that perhaps this will
allow an operator to query the state of the volumes now.

Most of this was hashed out privately.

christos