Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/pci

> The 'reg' variable is of type 'uint32_t'.
> So why using bus_space_read_8() when
> bus_space_read_4() gives the same result?

Did you confirm if it really gave the same result?
Some bus/device might require certain access size on I/O.

I don't know if the device have such restriction,
but "making ALL buildable" can't be an excuse for
changes without tests in this case.
Izumi Tsutsui

Home | Main Index | Thread Index | Old Index