Re: CVS commit: src/sys/dev

[christos%astron.com@localhost (Christos Zoulas)]

In article <20101205093557.GA24524%cs.hut.fi@localhost>,
Antti Kantee  <pooka%cs.hut.fi@localhost> wrote:
>On Sat Dec 04 2010 at 18:44:07 +0000, Christos Zoulas wrote:
>> In article <20101204173951.3AE6E175DF%cvs.netbsd.org@localhost>,
>> Antti Kantee <source-changes-d%NetBSD.org@localhost> wrote:
>> >-=-=-=-=-=-
>> >
>> >Module Name:        src
>> >Committed By:       pooka
>> >Date:               Sat Dec  4 17:39:51 UTC 2010
>> >
>> >Modified Files:
>> >    src/sys/dev: rnd.c
>> >
>> >Log Message:
>> >Don't allow "goes to 11^H^Hhyperspace" len field for RNDADDATA.
>> >
>> 
>> Should be EINVAL; E2BIG has a very specific meaning (unless we want to change
>> that).
>
>EINVAL is used too much and I try to pick more descriptive remotely
>fitting errnos when possible.
>
>If someone feels strongly otherwise, please change it.

I agree with the overuse of EINVAL and I have tried in the past to avoid it.
What I am saying is that if we are going to re-purpose other errnos, we need
to change their descriptions to make them less specific.

christos