Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/powerpc/oea

>>>>> On Sun, 14 Nov 2010 05:52:51 +0000,
        David Holland <> said:

> On Sun, Nov 14, 2010 at 03:32:44AM +0000, Masao Uebayashi wrote:
>> XXX What is the conclusion about direct vs. indirect #include from headers?
> Every header file should include the things it requires to compile.
> Therefore, there should in principle be no cases where a header file
> (or source file) needs to #include something it doesn't itself use.

Well, there is another thing which has to be considered.  That is
name space pollution.
Header files which are exported to userland (for userland visible APIs)
should not export random symbols.  Only symbols which are defined as
the interface of the header file are allowed to be exported.

It seems the <sys/param.h> change is safe about this point though,
because all definitions of the uvm_param.h seem to be protected
by defined(_KERNEL).

Home | Main Index | Thread Index | Old Index