Re: CVS commit: src/sys/sys

[Martin Husemann <martin%homeworld.netbsd.org@localhost>]

On Sat, Nov 13, 2010 at 08:41:41AM +0000, Masao Uebayashi wrote:
> Module Name:  src
> Committed By: uebayasi
> Date:         Sat Nov 13 08:41:41 UTC 2010
> 
> Modified Files:
>       src/sys/sys: param.h
> 
> Log Message:
> Include uvm/uvm_param.h from here to provide PAGE_SIZE and other
> VM related constants.  Many users of uvm/uvm_extern.h in subsystems
> are interested in only PAGE_SIZE.  The whole uvm/uvm_extern.h is
> not necessary at all.

This breaks the build at least on VAX like this:

In file included from ./machine/cpu.h:209,
                 from ./machine/lock.h:43,
                 from ../../../../sys/lock.h:74,
                 from ../../../../uvm/uvm_param.h:75,
                 from ../../../../sys/param.h:141,
                 from /tmp/genassym.6254/assym.c:4:
../../../../sys/lwp.h: In function 'lwp_eprio':
../../../../sys/lwp.h:409: error: 'PRI_KERNEL' undeclared (first use in this 
function)
../../../../sys/lwp.h:409: error: (Each undeclared identifier is reported only 
once
../../../../sys/lwp.h:409: error: for each function it appears in.)
cc1: warnings being treated as errors
../../../../sys/lwp.h:411: warning: implicit declaration of function 'MAX'


since PRI_KERN etc. are only defined later in param.h, way after the include
of uvm_param.h that you added.

Martin