Re: CVS commit: src/sys/dev/ieee1394

[Adam Hoka <adam.hoka%gmail.com@localhost>]

On Tue, 31 Aug 2010 08:31:27 +0200
Christoph Egger <Christoph_Egger%gmx.de@localhost> wrote:

> On 26.08.10 16:31, Mindaugas Rasiukevicius wrote:
> >> Module Name:    src
> >> Committed By:   cegger
> >> Date:           Thu Aug 26 12:48:19 UTC 2010
> >>
> >> Modified Files:
> >>         src/sys/dev/ieee1394: fwdev.c
> >>
> >> Log Message:
> >> don't call tsleep() with any mutexes hold
> >>
> >>
> >> To generate a diff of this commit:
> >> cvs rdiff -u -r1.23 -r1.24 src/sys/dev/ieee1394/fwdev.c
> > 
> > The right fix would be to use condvar(9).  Generally, tsleep(9) should
> > be replaced and removed in the longer term.
> 
> Sure. Two questions hold me back from doing this:
> 1. Which cv_*wait* variant should be used?

I used cv_wait_sig when porting a piece of code from tsleep,
but it dpends on what do you want to do. (cv_timedwait(,_sig) if you
want timeout)

> 2. Where should I add the corresponding cv_signal/cv_broadcast ?

where the wakeup(9) was, if theres no need to signal, use kpause(9).

> Is it possible to have an conversion example in the tsleep(9) manpage?
> 
> Christoph

ps.: someone correct me if i wrote something stupid :)

-- 
NetBSD - Simplicity is prerequisite for reliability