Re: CVS commit: src/sys

[Antti Kantee <pooka%cs.hut.fi@localhost>]

On Thu Jul 29 2010 at 10:54:52 +0000, Juergen Hannken-Illjes wrote:
> Module Name:  src
> Committed By: hannken
> Date:         Thu Jul 29 10:54:51 UTC 2010
> 
> Modified Files:
>       src/sys/arch/sparc64/sparc64: pmap.c
>       src/sys/kern: vfs_subr.c
>       src/sys/miscfs/genfs: genfs_io.c
>       src/sys/rump/librump/rumpkern: vm.c
>       src/sys/ufs/lfs: lfs_vnops.c
>       src/sys/uvm: uvm_aobj.c uvm_page.h
> 
> Log Message:
> Add vm page flag PG_MARKER and use it to tag dummy marker pages
> in genfs_do_putpages() and uao_put().
> Use 'v_uobj.uo_npages' to check for an empty memq.
> Put some assertions where these marker pages may not appear.

Can you explain why you added a KASSERT for no marker pages to
uvm_pagelookup()?  genfs_do_putpages calls uvn_findpages which calls
uvn_findpage which calls uvm_pagelookup ... which would have been
instantly revealed by running the test suite.