Re: CVS commit: src/sys/dev/pci

[David Young <dyoung%pobox.com@localhost>]

On Fri, Jun 25, 2010 at 01:10:13PM +0900, masanobu%iij.ad.jp@localhost wrote:
> 
> From: SAITOH Masanobu <msaitoh%netbsd.org@localhost>
> Subject: CVS commit: src/sys/dev/pci
> Date: Fri, 25 Jun 2010 03:47:58 +0000
> 
> > Module Name:        src
> > Committed By:       msaitoh
> > Date:               Fri Jun 25 03:47:57 UTC 2010
> > 
> > Modified Files:
> >     src/sys/dev/pci: if_wmreg.h
> > 
> > Log Message:
> > The GIO master enable bit in STATUS register is not bit 16 but bit 18.
> > It will fix a problem on 82580 SGMII system.
> 
> This is wrong. I've cvs admined with the following message:
> 
>   The GIO master enable bit in STATUS register is not bit 16 but bit 18.
>   It will fix a problem in the reset sequence on PCI-e chips.

Is it 18 or 19?

-#define        STATUS_GIO_M_ENA (1U << 16)     /* PCIX master enable */
+#define        STATUS_GIO_M_ENA (1U << 19)     /* GIO master enable */

Use __BIT(3) ?

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933