Re: CVS commit: src/sys/net/agr

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

hi,

> Module Name:  src
> Committed By: dyoung
> Date:         Wed May 26 23:46:44 UTC 2010
> 
> Modified Files:
>       src/sys/net/agr: if_agr.c if_agrvar_impl.h
> 
> Log Message:
> Change sc_wrports from an int to a bool and "test truth" instead of
> comparing with 0.
> 
> Add 'volatile' to several other state variables that need it.

can you explain why they need to be volatile?  aren't they protected
by a mutex?

btw, i'm not sure why this driver needs this complicate locking.
i guess it's better to (re?)design locking protocol for ifioctl before
putting this complicity to drivers.

YAMAMOTO Takashi

> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.27 -r1.28 src/sys/net/agr/if_agr.c
> cvs rdiff -u -r1.9 -r1.10 src/sys/net/agr/if_agrvar_impl.h
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.