Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ieee1394

On May 24, 10:32pm, (KIYOHARA Takashi) wrote:
-- Subject: Re: CVS commit: src/sys/dev/ieee1394

| Hi!
| From: Izumi Tsutsui <>
| Date: Mon, 24 May 2010 22:08:21 +0900
| > > Why you revert it all?
| > 
| > Wasn't it broken?
| Yes. It knows I was broken, too. However, it worked on my ofppc and
| it booted my amd64.

Try booting with DIAGNOSTIC. If you make any changes to the kernel you should
be really compiling with DIAGNOSTIC.

| > > I had been investigating the problem of kmem since last week.  Was not
| > 
| > There is no reason to leave kernels broken even if
| > you have some idea for proper fixes.
| In many cases, there is a case that cannot be fixed in several days.  For
| instance, MIPS cannot be booted since merge mips64.

This is not also not acceptable it has pissed off everyone owning a MIPS box
who cannot boot current. If I had a MIPS box and could test this, I would
have reverted the MIPS changes too. (Hi Matt!).

I just want to highlight that this is not personal and it does not matter
who makes the changes. If you break HEAD and you leave it broken for days,
without communicating status, consider your changes a candidate for backout.

I want to also stress that I tried to fix the firewire code; I fixed two
issues already, and then I saw that it would require a lot of reworking
to fix the xfer code. I filed a PR, and I backed out the changes because
in my judgement there is no quick and easy fix for it. Prove me wrong
and commit today or tomorrow a change that works.


Home | Main Index | Thread Index | Old Index