Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/make

On Wed, May 05, 2010 at 10:10:39AM -0400, Christos Zoulas wrote:
 > Revert bogus patch that attempted to canonicalize a non absolute
 > argv[0] using realpath(3). Consider: touch Makefile; mkdir make;
 > make. This will set $MAKE to $PWD/make so further attempts to use
 > ${MAKE} will try to execute the directory. This needs $ORIGIN to be
 > fixed properly, or alternatively one can duplicate the logic for
 > execvp(3) and search the path for the make executable. Not worth
 > it. It was working just fine before!

It wasn't really; the specific point was to cause

   % ../../tooldir-*/bin/nbmake-foo [whatever]

to not break if it recursed into a subdir, which is a fairly common
case (for me at least).

It should have been leaving argv[0] alone if it didn't contain a '/',

David A. Holland

Home | Main Index | Thread Index | Old Index