Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/miscfs/specfs



On Tue, Apr 13, 2010 at 03:27:11PM +0300, Antti Kantee wrote:
> On Tue Apr 13 2010 at 12:18:38 +0000, Andrew Doran wrote:
> > On Tue, Apr 13, 2010 at 10:47:51AM +0300, Antti Kantee wrote:
> > > On Tue Apr 13 2010 at 01:15:56 +0000, Adam Hoka wrote:
> > > > Module Name:    src
> > > > Committed By:   ahoka
> > > > Date:           Tue Apr 13 01:15:56 UTC 2010
> > > > 
> > > > Modified Files:
> > > >         src/sys/miscfs/specfs: spec_vnops.c
> > > > 
> > > > Log Message:
> > > > Autoload modules with any class.
> > > > 
> > > > This fixes autoloading of pf, zfs and possibly others.
> > > 
> > > What is wrong with making drivers MODULE_CLASS_DRIVER?  I think we
> > > should limit autoload aiming for safety, not splatter it all over.
> > > 
> > > Eventually everything will of course be fixed by, *tadaa*, devfs.
> > > Meanwhile, please back this out and if you don't think calling a driver
> > > a driver is the right thing to do, have a discussion.
> > 
> > What's the problem with autoloading any class?  Is it just a cosmetic thing?
> 
> I already mentioned my opinion above: "aim for safety".  Since there
> is currently no common place to manage the different names we have,
> I don't want to discover some day that e.g. some secmodel name matches
> a devsw name.

So the kernel of the problem is namespace collisions, correct?

Would you agree that's it's the kernel programmers responsibility
to avoid conflicts?

If so how about sprinkling a little process in order to make it harder to
screw up?



Home | Main Index | Thread Index | Old Index