Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/isa



dyoung%pobox.com@localhost said:
> Let us add a bus_space_is_equal(bus_space_tag_t t1, bus_space_tag_t
> t2) for implementation in MD code

That's generally OK. (We have this in pthread_equal().)

>        return memcpy(&t1, &t2, sizeof(t1)) == 0;
> That will work even if bus_space_tag_t is a struct.

I hope you don't really consider to pass structs as arguments to
functions. Int-alikes and pointers make sense, but I doubt anything
else does. But then, a bus_space_is_equal() doesn't buy us much,
it only adds bloat.

best regards
Matthias




------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
Forschungszentrum Juelich GmbH
52425 Juelich
Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzende des Aufsichtsrats: MinDir'in Baerbel Brumme-Bothe
Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
Prof. Dr. Sebastian M. Schmidt
------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------


Home | Main Index | Thread Index | Old Index