[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src
On Jan 30, 10:30am, tsutsui%ceres.dti.ne.jp@localhost (Izumi Tsutsui) wrote:
-- Subject: Re: CVS commit: src
| > 4. Could be. I don't like to code solutions for future/non existing
| > problems though.
| Well I had a patch with the solution and was waiting feedback,
| but you beated me without any comments for my patch.
| I was disgusted a bit since I spent a day to prepare the patch. Sorry.
I am sorry bacause I did not notice. I just saw the mail about the struct
winsize problem, I though it would be better to not expose the struct so
I fixed it. Then you mentioned asnprinf, and I saw that it was not used
so I removed it. I am of the opinion that if you can avoid conditional
compilation by writing portable code you should. Also you should avoid
extra copies of the code if you can. If you don't agree, please go ahead
undo my changes and commit the patch in the PR.
Main Index |
Thread Index |