Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/acpi

On Fri, 4 Dec 2009, Quentin Garnier wrote:

IMO, very few devices should attach at acpi, but autoconfiguration
should use ACPI data, when it is available, for the "direct"
configuration of devices that we would otherwise have to probe for.

Was there ever a disagreement on that?

Well, one place where this might not work is for ACPI-accessible i2c busses! The acpi code might well be manipulating the bus without obeying any i2c_acquire_bus() locking mechanism implemented in the "native" pci-based drivers, with unpredictable results. (Consider the case where an acpitz might be using an i2c-connected sensor...)

I fail to see how the API that was just committed will not result in a
#if NACPI > 0 block every time it is used.

Yeah, and that would be, ahem, ugly.

|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:      |
| Customer Service | FA29 0E3B 35AF E8AE 6651 |  paul at   |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index