Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch

> Module Name:  src
> Committed By: cegger
> Date:         Mon Oct 26 19:16:59 UTC 2009
> Modified Files:
 [ >80 files ]
> Log Message:
> kill extra whitespaces
> reviewed by tsutsui@

Well, I glanced at your large >2000 line diff and gave a comment
"if all (or most) of them have been checked compile
 (i.e. no obvious botches), no problem for me,"
but I doubt we can note it as "reviewed."

IMO, "review" should be done against design and implementation.
On such a large set of mechanical changes, you should rather
mention how you put the changes (by tools, or by your hands etc.)
and what checks you have done for them, so that future readers
who might be hit by potential failures will be able to track
possible changes in the log.

Izumi Tsutsui

Home | Main Index | Thread Index | Old Index