Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.sbin/puffs/rump_smbfs

On Mon Sep 14 2009 at 08:15:36 +0100, Nick Hudson wrote:
> > In the future if you run across a problem which you are unable to
> > understand, debug and fix on your own, please ask for assistance.
> > Commits with handwavy and incorrect information make it more difficult
> > to track down and fix the real issues.
> I tried to contact you on several occasions, but you chose to ignore me. 
> *shrug*

I'm sorry, then.  The commit messages and this are the only emails I've
seen from you on the subject.  Maybe you should quote something like
"no comment from foo" in a commit message in the future?

> > The binutils regression is that between 2.16 and 2.19 __start_sectname
> > for orphaned sections was changed to use PROVIDE instead of define and
> > hence those symbols are not available anymore in library components
> > produced with ld.  I have provided a quick workaround which allows the
> > build to work with both with 2.16 and 2.19 while not silently breaking
> > functionality like in your model.
> >
> > Please revert all of your incorrect commits.
> Feel free to fix rump and linksets correctly. It's been explained to you why 
> they can't work properly together.

rump hasn't relied on linksets since August 2008 (and even then there was
only a few day window of linkset use after introducing dynamic linking
to rump).  The only thing that matters is the entry point, which,
incidentally, is what binutils 2.19 chaged.

Home | Main Index | Thread Index | Old Index