Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/etc/rc.d



> On Tue, 08 Sep 2009, Christoph Egger wrote:
> > > > Do not flush routes if root file system is nfs mounted.
> > > > Fixes boot problem when the nfs server is in a different
> > > > subnet.
> > > 
> > > Why do you need this special case code, when a simple
> > > flushroutes=NO in /etc/rc.conf will do the job?
> > 
> > I prefer a default value that works out-of-the box.
> 
> So do I, but why is flushroutes true out of the box?  Isn't that
> the right thing to fix?

I am not sure.

> > there's another problem still to address:
> > 
> > if you have multiple interfaces and you have
> > 'dhcp' in /etc/ifconfig.<if> then
> > dhcpcd tries to remove and re-add the default route.
> > dhcpcd shouldn't touch the default route if root is on NFS
> > because you end up with
> 
> I still don't see why "root on NFS" is the right condition to
> use in a test for whether to flush routes or to change the
> default route.  For example, if root is local but /var is on
> NFS, you will get similar problems.

We can extend rc.subr with a function which determines if we
mount nfs and if we have root-on-nfs and exports corresponding
variables set to yes or no.

All scripts can use them to easily test "root on NFS".

> Perhaps a better test would be that dhcpcd shouldn't touch
> the default route unless the default route is through the
> interface that dhcpcd is managing.

I agree.
How should dhcpcd deal with /etc/resolv.conf ?
If dhcpcd removes and rewrites the entries, DNS queries in-between
may fail (i.e. mounting nfs)

Christoph


Home | Main Index | Thread Index | Old Index