Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/uvm

On Sat, Apr 18, 2009 at 01:46:43PM +0200, Christoph Egger wrote:
> Christos Zoulas wrote:
> This would imply to change the flags arguments of the pmap API
> from int to u_int to avoid troubles with checking flag bits.
> Alternatively, code like this
>     if (flags & FLAG1)
>         do_something();
> must be converted to
>     if ((flags & FLAG1) == FLAG1)
>         do_something();

Why? If we assume that flags will actually hold FLAG1, then I don't see 
how signed vs unsigned will matter.

Take care,


Attachment: pgp3zAQ133Ujh.pgp
Description: PGP signature

Home | Main Index | Thread Index | Old Index