Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/gpio



On Sun, Jul 26, 2009 at 5:26 PM, matthew green<mrg%eterna.com.au@localhost> 
wrote:
> incidentially, i actually did object to this change on ICB last night
> but i was off to bed and didn't feel like arguing at the time.  i
> didn't expect to see it commited straight away.  so marc's claim that
> it did not get any objections is infact not entirely right.
>
OOTH, it's not like the code in question was already heavily used:

-/* $NetBSD: gpiosim.c,v 1.1 2009/07/25 16:17:10 mbalmer Exp $ */
+/* $NetBSD: gpiosim.c,v 1.2 2009/07/26 13:45:20 mbalmer Exp $ */

I join perry@ on this thread, and chritos@ too as this should have
been privately discussed.

 - Arnaud

ps:  I consider rules as strongly recommended guidelines. What is
beautiful with software, is that is can be pretty easily changed and
fixed. We're not building bridge that will have to live 100 years
supporting an ever increasing traffic, or even space shuttle.

ps2: just by looking at the commit log, I would find the interface a
bit too FreeBSD'ish (ie. [ab]using sysctl(4)).


Home | Main Index | Thread Index | Old Index