Re: CVS commit: src/usr.bin/xinstall

[Alan Barrett <apb%cequrux.com@localhost>]

On Sat, 25 Jul 2009, Andreas Gustafsson wrote:
>       src/usr.bin/xinstall: xinstall.c
> 
> Log Message:
> When installing via a temporary file, base the name of the temporary
> file on the name of the target file, not just the target directory, to
> ensure uniqueness when multiple concurrent invocations of install(1)
> simultaneously install files in the same directory.  Fixes bin/41512.

The comment about /* This usage is safe */ for the mktemp() call
is cleary inaccurate.  I think this should be fixed by using mkstemp().

--apb (Alan Barrett)