Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/ddb



Hello,

[ CC source-changes-d ]

> > ...
> > 
> > Modified Files:
> >     src/sys/ddb: db_command.c db_xxx.c
> >
> > Log Message:
> > Add #ifdef MQUEUE for db_show_mqueue_cmd().
> >
> > XXX: Wrong.  DDB should be dynamic, modular, etc.
> 
> 
> It should be already possible to dynamically add command to ddb.
> 
> ...
> 
> (void)db_register_tbl_entry(DDB_SHOW_CMD, &db_show_cmd_builtins);

db_register_tbl_entry() is not exported as public API, but you are right,
there is db_register_tbl(). There is even one user (in the whole tree).

I doubt if it's worth bothering at this stage - good chunk of DDB could
rather be rewritten to make it really modular and simple (now it's not).

-- 
Mindaugas


Home | Main Index | Thread Index | Old Index