Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys



Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost> writes:
> marc%msys.ch@localhost wrote:
>> Does this mean that adding ioctls in a driver needs core approval?
>> Or "only" changing existing ABIs/APIs ?
>
> It's always better thing to discuss (or propose) on mailing list.

I somewhat disagree. Often something is so trivial that the discussion
is essentially a waste of time -- it is not always better to discuss
something, just some (perhaps most) of the time.

Discussing things is important if your change is "significant
enough". Unfortunately, when that is cannot be explained by a hard and
fast rule -- one has to learn what is considered significant enough.

My rule is this -- if I would be upset that someone else had made a
change without discussing it, or if I am not very sure I'm doing the
right thing, it clearly is something I need to discuss.

> You can also consult your sponsors first, of course.

Always a good thing to do when one is a new developer.

-- 
Perry E. Metzger                perry%piermont.com@localhost


Home | Main Index | Thread Index | Old Index