Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src

> > Modified Files:
> >     src/common/lib/libc/hash/sha2: sha2.c
> >     src/sys/lib/libkern/arch/vax:
> > 
> > Log Message:
> > Back out the addition of memset.c to the vax libkern, and instead do
> > as tsutsui@ suggested, and include <sys/param.h> in sha2.c instead.
> > On the vax, this causes <machine/macros.h> to be included, and it contains
> > that machine's memset() macro+inline.
> I object this change to sha2.c. At the very least the include should be
> in the kernel only section.

Indeed, that what md4c.c does.

> Besides, I would call this a bug in VAX --
> including libkern's headers should be good enough. If it isn't, that
> should be fixed.

Yes, but adding <sys/param.h> to sha2.c (in _KERNEL) is still
better workaround than adding memset.c into libkern.

I agree memset(9) for vax should be fixed,
but I'm afraid it would require more thoughts.
Izumi Tsutsui

Home | Main Index | Thread Index | Old Index