Re: CVS commit: src/sys

[David Young <dyoung%pobox.com@localhost>]

On Fri, May 29, 2009 at 04:57:05AM +0000, Darran Hunt wrote:
> Module Name:  src
> Committed By: darran
> Date:         Fri May 29 04:57:05 UTC 2009
> 
> Modified Files:
>       src/sys/dev/pci: if_wm.c
>       src/sys/net: if_ethersubr.c
>       src/sys/net/agr: ieee8023ad_lacp.c if_agr.c if_agrether.c
>           if_agrvar_impl.h
> 
> Log Message:
> Add vlan support and hardware offload capabilities to agr.
> These changes allow vlans to be layered above agr, with the attach
> and detach propogated to the member ports in the aggregation.
> Note the agr interface must be up before the vlan is attached.
> 
> Adds SIOCINITIFADDR support to the wm driver for setting the AF_LINK
> address, necessary for agr to be able to set the mac addresses of each
> port to the agr address (i.e. so it can receive all intended traffic
> at the hardware level).

Please use SIOCALIFADDR for this.  It will work with many more drivers,
and you will be able to discard agr(4)'s code for saving the old
link-layer address, because you get that with SIOCALIFADDR for free. :-)

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933