Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys



On Sat, 16 May 2009, Andrew Doran wrote:
> Thanks! How about this to avoid potential sign compare issues? I forgot
> to e-mail you about it earlier.
> 
> @@ -252,8 +252,8 @@ typedef struct vnode vnode_t;
>  /*
>   * v_usecount; see the comment in vfs_subr.c
>   */
> -#define        VC_XLOCK        0x80000000
> -#define        VC_MASK         0x7fffffff
> +#define        VC_XLOCK        0x40000000
> +#define        VC_MASK         (0xffffffff & ~VC_XLOCK)

It may be easier and safer to use 0x7fffffffUL.

--apb (Alan Barrett)


Home | Main Index | Thread Index | Old Index