Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/sys/netinet



   Quentin Garnier wrote:
   > On Tue, May 12, 2009 at 09:48:42PM +0000, Elad Efrat wrote:
   >> Module Name:      src
   >> Committed By:     elad
   >> Date:             Tue May 12 21:48:42 UTC 2009
   >>
   >> Modified Files:
   >>   src/sys/netinet: ip_carp.c
   >>
   >> Log Message:
   >> Fix inverted permissions check.
   >> -         if ((l == NULL) || (error = kauth_authorize_network(l->l_cred,
   >> +         if ((l != NULL) || (error = kauth_authorize_network(l->l_cred,
   > 
   > That can't be right.  If l is NULL, then it should be dereferenced?
   
   Right, fixed, thanks!


actually, you can remove all the check for l vs NULL
in this file.  they are useless since yamt-idlelwp.


.mrg.
   


Home | Main Index | Thread Index | Old Index