On Tue, May 12, 2009 at 05:15:05PM +0100, Robert Swindells wrote:
>
> Christoph Egger wrote:
> >> Valeriy E. Ushakov wrote:
> >> >On Tue, May 12, 2009 at 14:18:16 +0000, Christoph Egger wrote:
> >>
> >> >> struct device * -> device_t, no functional changes intended.
> >>
> >> >Why don't you cmp(1) the objects before and after to verify that?
> >> >"Same object code generated" is, unlike intentions, something
> >> >that can be verified.
> >>
> >> A fair number won't be the same, I would guess half our SCSI
> >> drivers are currently broken.
> >>
> >> Do a search in sys/dev/ic for 'adapt_dev', any driver that casts
> >> this to a softc instead of calling device_private() will crash.
>
> >The cast is a bug in drivers which have
> >the device_t/softc split already done. It is harmless
> >for those not yet splitted.
>
> Maybe ahc(4) was the only one that was broken. The point is that you
> could have found this by comparing the object files.
Ok, so, just to clarify:
- changing struct device * to device_t is pure cosmetics
- problem arise with botched device_t/softc split, which is a
different thing, and *is* a functional change.
That means that cegger *did* break ahc when he did the split for ahc, so
thank you for fixing it.
Now, of course, that doesn't come as a surprise. Some people just never
learn or listen. Or apologise.
--
Quentin Garnier - cube%cubidou.net@localhost - cube%NetBSD.org@localhost
"See the look on my face from staying too long in one place
[...] every time the morning breaks I know I'm closer to falling"
KT Tunstall, Saving My Face, Drastic Fantastic, 2007.
Attachment:
pgp_Jv3UlqdgU.pgp
Description: PGP signature