Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/uvm

On Apr 18,  1:46pm, (Christoph Egger) wrote:
-- Subject: Re: CVS commit: src/sys/uvm

| This would imply to change the flags arguments of the pmap API
| from int to u_int to avoid troubles with checking flag bits.

As it should have been in the first place, so change it.

| Alternatively, code like this
|     if (flags & FLAG1)
|         do_something();
| must be converted to
|     if ((flags & FLAG1) == FLAG1)
|         do_something();

This is overkill.


Home | Main Index | Thread Index | Old Index