Re: CVS commit: src/crypto/dist/openssl/apps

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Tue, 14 Apr 2009 16:11:13 +0200
    From:        Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
    Message-ID:  <20090414141113.GD952%britannica.bec.de@localhost>

  | toupper() gets u_char arguments, not int. This cast is simply wrong.

According to TFM ...

SYNOPSIS
     #include <ctype.h>

     int
     toupper(int c);

and

CAVEATS
     The argument to toupper() must be EOF or representable as an unsigned
     char; otherwise, the behavior is undefined.

If EOF is to be a valid parameter to toupper(), then the arg type
cannot be u_char - however much you'd like it to be.

kre