Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/fs/tmpfs

Andrew Doran <> writes:
> On Sat, Apr 11, 2009 at 12:21:57AM +0000, Perry E. Metzger wrote:
>> Modified Files:
>>      src/sys/fs/tmpfs: tmpfs_vnops.c
>> Log Message:
>> SAVENAME was not set for rename and delete as required
>> Patch from christos, fixes pr 41183
> Now it leaks pathname buffers.
> Who reviewed this change and who okayed it?

The patch came from christos. He told me to commit it. I would have
thought that was obvious from the commit message.

Until it was put into place, builds that I did reliably paniced my
machine in tmpfs. If the fix is broken, well, please fix the fix or talk
to Christos about it.

As a side note: my fastest box, a Q9550 (quad core 2.8GHz 12M cache)
with 4G of memory and maxvnodes bumped up so that it does virtually no
i/o quite reliably dies doing ./ in various places, some of them
rather bizarre and hard to debug. A couple of them so far have
corresponded to known bugs like the tmpfs issue.

Extensive testing, including running other OSes, seems to indicate that
the hardware is not at fault. It would be rather nice to get the
associated races etc. fixed so the machine would operate reliably.

Perry E. Metzger      

Home | Main Index | Thread Index | Old Index