Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/distrib/sets wrote:

> > Log Message:
> > Explicitly sort entries on preparing set files from METALOG.
> > METALOG could have different order due to install(1) race
> > on parallel builds, and mtree(8) doesn't sort files.
> > Should fix inconsistent shared sets among builds as seen in
> > /pub/NetBSD-daily/netbsd-5/200904010000Z/shared/ and
> > /pub/NetBSD-daily/netbsd-5/200904010002Z/shared/ dirs.
> > Okay'ed by snj@.
> I think the invocation of "mtree -C" may have also had the effect of
> sorting, in which case this is redundant.

No. It reorders directories only, not files in the same directories.

% obj.news68k/tooldir.NetBSD-5.99.8-i386/bin/nbmtree -C -k all -R time \
-N obj.news68k/destdir.news68k/etc < obj.news68k/destdir.news68k/METALOG

./usr/games/monop type=file uname=root gname=wheel mode=0555 
./usr/games/number type=file uname=root gname=wheel mode=0555 
./usr/games/morse type=file uname=root gname=wheel mode=0555 
./usr/games/phantasia type=file uname=root gname=games mode=02555 

> You might want to check
> quickly.

Did you commit your change without build and test? ;-p

I checked it as noted in the log.

Izumi Tsutsui

Home | Main Index | Thread Index | Old Index