[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys
On Wed, Mar 25, 2009 at 11:15:16PM +0900, Izumi Tsutsui wrote:
> tls%rek.tjls.com@localhost wrote:
> > What was added to libkern is much simpler than what's in libz (not just
> > because the libz sources are stylistically gross). It's not only meant
> > for use by libz.
> Even if so, it should be handled by .PATH.c: in libkern/Makefile.libkern
> to pull crc32.c, IMO.
I disagree. For example, the unmodified crc32.c in libkern does byte
order checking at runtime, which is just pointless in the kernel. The
libz source is so dirty, if we have to clean it up at all for in-kernel
use, better, I think, to just extract the useful part of that file and
maintain it ourselves.
It is my intent to add a _much_ smaller crc32 function for use by
STANDALONE so that even libz built into the bootblocks doesn't use the
code from common/dist/libz.
Main Index |
Thread Index |