Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/netiso

Havard Eidnes <> writes:
> Module Name:  src
> Committed By: he
> Date:         Wed Mar 18 22:08:57 UTC 2009
> Modified Files:
>       src/sys/netiso: tp_input.c tp_usrreq.c
> Log Message:
> Correct a couple of bcopy() -> memcpy() conversions which did not
> properly handle their arguments.

Given the existing macros in systm.h already meant these were expanded
into mem* calls, this failure would have been caught if someone had
compared binaries before and after the rototill.

It is important that people actually test these things. Big rototills
are often easy enough to make completely safe if people do adequate
checks, but it seems that they're not doing them.


Home | Main Index | Thread Index | Old Index