Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/libc/iconv

On Tue, Mar 03, 2009 at 11:27:57AM -0600, Michael Graff wrote:
> Hash: SHA1
> Joerg Sonnenberger wrote:
> > On Tue, Mar 03, 2009 at 02:39:07PM +0000, Michael Graff wrote:
> >> Log Message:
> >> Ignore the magic // commands in iconv_open().  This was discussed on
> >> current-users about a month ago, and ignoring the options was the best
> >> suggestion.
> > 
> > Please don't just randomly ignore option arguments. At the very least
> > check for *what* options are ignored. While it might be acceptable to
> > ignore //ignore, I am already oppossing ignoring //translit. Wildcard
> > ignores like this are completely inacceptable though.
> - From what I've read, //translit is not guaranteed to work, it's a
> best-effort thing.  You can still end up with garbage in your strings,
> and therefore cannot rely on the output being safe for, say, filenames.

translist is for making best-effort to give useful output. That's
different from just ignoring unknown characters. Best examples are
replacing currency signs with the spelt out version.
I'm also not sure if //ignore is supposed to handle *input* errors as


Home | Main Index | Thread Index | Old Index