[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: merge bouyer-xenpvh to HEAD
The built-in nvmm module worked - prior to the structure change.
I'll carry on another update to see if I can take it out of the definition.
On Mon, 27 Apr 2020 at 17:40, Manuel Bouyer <bouyer%antioche.eu.org@localhost> wrote:
> On Mon, Apr 27, 2020 at 06:30:14PM +0200, Maxime Villard wrote:
> > Not necessarily, the other #ifdefs are at the end of the structure, and they
> > deal with fields that modules are not "expected" to access. The problem we
> > see here is caused by the fact that the XEN #ifdef is at the _beginning_ of
> > the structure, and so the offset of several public fields will differ between
> > modules and the kernel.
> > I would suggest that the field be moved down; quickly, if possible, because
> > NVMM is not the only module that accesses some parts of curcpu(), and chances
> > are that many other modules are broken too.
> OK, done.
> This module stuff is really a mess ...
> Manuel Bouyer <bouyer%antioche.eu.org@localhost>
> NetBSD: 26 ans d'experience feront toujours la difference
Main Index |
Thread Index |