Port-xen archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: merge bouyer-xenpvh to HEAD



On Mon, Apr 27, 2020 at 01:36:10PM +0200, Maxime Villard wrote:
> Don't have time to look at that immediately, but after a very quick glance,
> it seems clear the problem is in the definition of struct cpu_info. There
> is an early #ifdef XEN that is true in the kernel but false in the module,
> leading to serious bugs. Try compiling the module with CFLAGS+=-DXEN, you'll
> probably see it works.
> 
> The ifdef should be moved to the end of the structure, like the rest.

If struct cpu_info is part of the module ABI, there's others #ifdef that
should be removed, isn't it ?

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--


Home | Main Index | Thread Index | Old Index